Solves issue #428 Linking error: SetPickingColor #430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves the linking errors which many users reported. This was reported on issue Heeks#428 Linking error: SetPickingColor.
Picking.cpp is required for HeeksCNC compilation but it's not currently installed by HeeksCAD.
I fixed wrong translations and replaced "y" with "&" in the menu titles translations which makes to show the icons correctly in the dropdown menus.
lpgasparotto
commented
Mar 13, 2020
|
@lpgasparotto Your translation improvements have been extracted from this PR and merged into master: 5c9410e Regarding the linking error, I reworked your job and moved the shared files ( Thanks for your contribution! |
|
You're welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the linking errors which many users reported. This was reported on issue #428 Linking error: SetPickingColor.